Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename is_major to is_clustering #2219

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Aug 8, 2024

@wayblink wayblink force-pushed the clustering-rename branch from c475b20 to fde6ebe Compare August 8, 2024 07:45
@mergify mergify bot added the ci-passed label Aug 8, 2024
@XuanYang-cn XuanYang-cn added the PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x label Aug 8, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 8, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change codes according to 2.4

Signed-off-by: wayblink <[email protected]>
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wayblink, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 38fa108 into milvus-io:master Aug 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants